RFR: 8324799: Use correct extension for C++ test headers [v2]
Kim Barrett
kbarrett at openjdk.org
Thu Feb 29 00:16:29 UTC 2024
On Wed, 28 Feb 2024 14:18:58 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - add Oracle copyright
>> - fix busted copyright text
>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetClassStatus/getclstat007/getclstat007.cpp line 28:
>
>> 26: #include "jvmti.h"
>> 27: #include "agent_common.hpp"
>> 28: #include "JVMTITools.hpp"
>
> There's a lower case jvmti_tools.hpp and an uppercase JVMTITools.hpp now. Maybe someone could do a cleanup of these tests (please!)
Agreed that's kind of odd, though not new (they were both previously .h files). There are lots of odd
things in vmTestbase tests - recall what the README.md in that directory says.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18035#discussion_r1506824801
More information about the serviceability-dev
mailing list