RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v7]
Suchismith Roy
sroy at openjdk.org
Tue Jan 16 08:46:27 UTC 2024
On Wed, 20 Dec 2023 13:29:05 GMT, Joachim Kern <jkern at openjdk.org> wrote:
>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Spaces fix
>
> src/hotspot/os/aix/os_aix.cpp line 1168:
>
>> 1166: int extension_length = 3;
>> 1167: char* file_path = NEW_C_HEAP_ARRAY(char, buffer_length + extension_length + 1, mtInternal);
>> 1168: strncpy(file_path,filename, buffer_length + 1);
>
> Why not using
> `char* file_path = os::strdup (filename);`
> which would replace lines 1167+1168
> and use the corresponding
> `os::free (file_path);`
> at the end
Ok. Any performance advantage to using that ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1453094259
More information about the serviceability-dev
mailing list