RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v7]
Joachim Kern
jkern at openjdk.org
Tue Jan 16 10:48:32 UTC 2024
On Tue, 16 Jan 2024 08:43:34 GMT, Suchismith Roy <sroy at openjdk.org> wrote:
>> src/hotspot/os/aix/os_aix.cpp line 1168:
>>
>>> 1166: int extension_length = 3;
>>> 1167: char* file_path = NEW_C_HEAP_ARRAY(char, buffer_length + extension_length + 1, mtInternal);
>>> 1168: strncpy(file_path,filename, buffer_length + 1);
>>
>> Why not using
>> `char* file_path = os::strdup (filename);`
>> which would replace lines 1167+1168
>> and use the corresponding
>> `os::free (file_path);`
>> at the end
>
> Ok. Any performance advantage to using that ?
No, I do not believe that it has performance advantage, but I think it is simpler to understand.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1453249951
More information about the serviceability-dev
mailing list