RFR: 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out

[Serguei Spitsyn]

On Thu, 11 Jul 2024 21:08:20 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Short version:
> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
> 
> Make additional typo fixes and tidyups while here, it's just shocking.
> 
> TestDescription.java contains the test definition, so the "requires" goes there, with a comment.
> 
> Updates to from001.java are typos and clarifications, and a changed loop with a poll on a queue rather than block forever.

Looks good. Posted a couple of nits.

test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001.java line 180:

> 178: 
> 179:                log.display("poolObjectName : " + poolObjectName +
> 180:                                   " resultObjectName : " + resultObjectName);

Nit: It'd be nice to fix the incorrect indent (it was in original code).

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20146#pullrequestreview-2173555008
PR Review Comment: https://git.openjdk.org/jdk/pull/20146#discussion_r1675023040