RFR: 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out [v2]

Kevin Walls kevinw at openjdk.org
Fri Jul 12 09:16:05 UTC 2024


> Short version:
> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
> 
> Make additional typo fixes and tidyups while here, it's just shocking.
> 
> TestDescription.java contains the test definition, so the "requires" goes there, with a comment.
> 
> Updates to from001.java are typos and clarifications, and a changed loop with a poll on a queue rather than block forever.

Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:

  formatting

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20146/files
  - new: https://git.openjdk.org/jdk/pull/20146/files/5aeed2ad..a6965231

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20146&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20146&range=00-01

  Stats: 26 lines in 1 file changed: 5 ins; 6 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/20146.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20146/head:pull/20146

PR: https://git.openjdk.org/jdk/pull/20146


More information about the serviceability-dev mailing list