RFR: 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out [v2]
Leonid Mesnik
lmesnik at openjdk.org
Thu Jul 18 00:57:37 UTC 2024
On Fri, 12 Jul 2024 09:16:05 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> Short version:
>> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
>>
>> Make additional typo fixes and tidyups while here, it's just shocking.
>>
>> TestDescription.java contains the test definition, so the "requires" goes there, with a comment.
>>
>> Updates to from001.java are typos and clarifications, and a changed loop with a poll on a queue rather than block forever.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>
> formatting
Marked as reviewed by lmesnik (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/20146#pullrequestreview-2184355125
More information about the serviceability-dev
mailing list