RFR: 8333827: JDK 23 RDP1 L10n resource files update [v2]
Pavel Rappo
prappo at openjdk.org
Tue Jun 11 11:06:17 UTC 2024
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> This issue is responsible for updating the translations of all the localize(able) resources in the JDK. Primarily, the changes between JDK 22 RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The translation tool adjusted some definitions, which causes some changes in localized files where the source file had no changes. This causes some words being reverted from localized languages to English, and some had its definitions changed.
>>
>> Alternatively, the diffs are viewable here and was generated using Jonathan Gibbons' diff tool for l10n:
>> https://cr.openjdk.org/~dnguyen/output2/
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove double quotes
I was asked to have a look at this PR elsewhere. I cannot verify correctness of translation, but I can review this PR generally for `jdk.javadoc`.
>From what I can see, the changes are only to the property files, which is expected from the PR title. The keys from English files 1-1 match the keys from non-English files: there are no missing or extra keys.
>From that point of view, the changes to `jdk.javadoc` look good.
-------------
Marked as reviewed by prappo (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19609#pullrequestreview-2110098592
More information about the serviceability-dev
mailing list