RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v2]

[Sean Mullan]

On Mon, 10 Jun 2024 16:52:26 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> JMX uses APIs related to the Security Mananger which are deprecated.  Use of AccessControlContext will be removed when Security Manager is removed.
>> 
>> Until then, updates are needed to not require setting  -Djava.security.manager=allow to use JMX authentication.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More consistent style of calls and comments.

A couple of comments so far; still reviewing.

test/jdk/javax/management/remote/mandatory/notif/NotificationEmissionTest.java line 36:

> 34:  * @run main NotificationEmissionTest 1
> 35: 
> 36:  * @run main/othervm NotificationEmissionTest 1

Lines 34 & 36: is it necessary to run NotificationEmissionTest twice with and w/o `othervm`?

test/jdk/javax/management/remote/mandatory/passwordAuthenticator/SimpleStandard.java line 155:

> 153:      */
> 154:     private void checkSubject() {
> 155:          Subject subject = Boolean.getBoolean("SimpleStandard.useGetSubjectACC") ?

Nit, remove extra leading space.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19624#pullrequestreview-2110572609
PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1634951807
PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1634955377