RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v2]

[Kevin Walls]

On Tue, 11 Jun 2024 14:02:17 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More consistent style of calls and comments.
>
> test/jdk/javax/management/remote/mandatory/notif/NotificationEmissionTest.java line 36:
> 
>> 34:  * @run main NotificationEmissionTest 1
>> 35: 
>> 36:  * @run main/othervm NotificationEmissionTest 1
> 
> Lines 34 & 36: is it necessary to run NotificationEmissionTest twice with and w/o `othervm`?

It's unnecessary, thanks.

> test/jdk/javax/management/remote/mandatory/passwordAuthenticator/SimpleStandard.java line 155:
> 
>> 153:      */
>> 154:     private void checkSubject() {
>> 155:          Subject subject = Boolean.getBoolean("SimpleStandard.useGetSubjectACC") ?
> 
> Nit, remove extra leading space.

got it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1635157731
PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1635157877