RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v6]

[Chris Plummer]

On Sat, 20 Apr 2024 03:04:23 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Lei Zaakjyu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/PointerLocation.java line 131:
> 
>> 129:   }
>> 130: 
>> 131:   public G1HeapRegion getHeapRegion() {
> 
> Do we want to rename to getG1HeapRegion?

It seems you agreed with this suggestion but the change was never made.

> test/hotspot/jtreg/serviceability/sa/TestG1HeapRegion.java line 62:
> 
>> 60:             agent.attach(Integer.parseInt(pid));
>> 61:             G1CollectedHeap heap = (G1CollectedHeap)VM.getVM().getUniverse().heap();
>> 62:             G1HeapRegion hr = heap.hrm().heapRegionIterator().next();
> 
> "g1HeapRegionIterator"?

And here also it seems you agreed with this suggestion but the change was never made.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18871#discussion_r1588433200
PR Review Comment: https://git.openjdk.org/jdk/pull/18871#discussion_r1588434351