RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v6]

Lei Zaakjyu duke at openjdk.org
Fri May 3 06:24:54 UTC 2024


On Thu, 2 May 2024 21:32:50 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/sa/TestG1HeapRegion.java line 62:
>> 
>>> 60:             agent.attach(Integer.parseInt(pid));
>>> 61:             G1CollectedHeap heap = (G1CollectedHeap)VM.getVM().getUniverse().heap();
>>> 62:             G1HeapRegion hr = heap.hrm().heapRegionIterator().next();
>> 
>> "g1HeapRegionIterator"?
>
> And here also it seems you agreed with this suggestion but the change was never made.

I think we can make these changes in later PRs in order to avoid making this one even larger.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18871#discussion_r1588784617


More information about the serviceability-dev mailing list