RFR: 8332042: Move MEMFLAGS to its own include file [v2]

Stefan Karlsson stefank at openjdk.org
Mon May 13 15:51:11 UTC 2024


On Mon, 13 May 2024 15:36:13 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> To quote @robehn - Why write a comment for a rule if you can enforce it with code instead...
>
> I tend to agree with that. My earlier question still stands: is there a better place to put it? Right now the "enforced with code" in a stand-alone file doesn't tell me "why" this rule is important.

If you want to keep the static_assert it in the .cpp file, then I won't block that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19172#discussion_r1598695748


More information about the serviceability-dev mailing list