RFR: 8332042: Move MEMFLAGS to its own include file [v2]

Thomas Stuefe stuefe at openjdk.org
Tue May 14 07:01:03 UTC 2024


On Mon, 13 May 2024 15:48:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> I tend to agree with that. My earlier question still stands: is there a better place to put it? Right now the "enforced with code" in a stand-alone file doesn't tell me "why" this rule is important.
>
> If you want to keep the static_assert it in the .cpp file, then I won't block that.

> Could you instead put the static_assert near the code that will break?

I like that. I will do that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19172#discussion_r1599476559


More information about the serviceability-dev mailing list