RFR: 8332071: Convert package.html files in `java.management.rmi` to package-info.java

Nizar Benalla nbenalla at openjdk.org
Sun May 19 19:08:01 UTC 2024


On Sun, 19 May 2024 18:47:50 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Please review this change. I converted the `package.html` file to `package-info.java`, because `javac` cannot recognize `package.html`.
>> I already brought this up [in the mailing list](https://mail.openjdk.org/pipermail/serviceability-dev/2024-May/055650.html).
>> The conversion was done in-place, only renaming it in git.
>> 
>> I also added a couple of `@since` tags, with only 2 changes I don't want to split these two fixes into separate PRs.
>> `CREDENTIALS_FILTER_PATTERN` and `SERIAL_FILTER_PATTERN` were first added in https://bugs.openjdk.org/browse/JDK-8187556
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/package-info.java line 26:
> 
>> 24:  */
>> 25: 
>> 26: /**
> 
> I assume you'll need to prepend each line with `*` too, which has the side effect of making it appear that every line is changed but I think we just need to get over that.

Doing that makes git think it's a new file, rather than a rename.
I was doing this in [a26ee08](https://github.com/openjdk/jdk/commit/a26ee085b5184d62a879f88f6cca6780e0e4e472) and removed it

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19263#discussion_r1606086468


More information about the serviceability-dev mailing list