RFR: 8332071: Convert package.html files in `java.management.rmi` to package-info.java
Kevin Walls
kevinw at openjdk.org
Mon May 20 10:35:02 UTC 2024
On Thu, 16 May 2024 10:39:43 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
> Please review this change. I converted the `package.html` file to `package-info.java`, because `javac` cannot recognize `package.html`.
> I already brought this up [in the mailing list](https://mail.openjdk.org/pipermail/serviceability-dev/2024-May/055650.html).
> The conversion was done in-place, only renaming it in git.
>
> I also added a couple of `@since` tags, with only 2 changes I don't want to split these two fixes into separate PRs.
> `CREDENTIALS_FILTER_PATTERN` and `SERIAL_FILTER_PATTERN` were first added in https://bugs.openjdk.org/browse/JDK-8187556
Looks good - with the asterisk * prefix question from the other comment.
I looked to check and yes the since 10 is correct.
-------------
Marked as reviewed by kevinw (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19263#pullrequestreview-2065901430
More information about the serviceability-dev
mailing list