RFR: 8332071: Convert package.html files in `java.management.rmi` to package-info.java [v3]
Roger Riggs
rriggs at openjdk.org
Mon May 20 18:56:07 UTC 2024
On Mon, 20 May 2024 18:15:16 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Please review this change. I converted the `package.html` file to `package-info.java`, because `javac` cannot recognize `package.html`.
>> I already brought this up [in the mailing list](https://mail.openjdk.org/pipermail/serviceability-dev/2024-May/055650.html).
>> The conversion was done in-place, only renaming it in git.
>>
>> I also added a couple of `@since` tags, with only 2 changes I don't want to split these two fixes into separate PRs.
>> `CREDENTIALS_FILTER_PATTERN` and `SERIAL_FILTER_PATTERN` were first added in https://bugs.openjdk.org/browse/JDK-8187556
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove tabs
src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java line 121:
> 119: *
> 120: * @since 10
> 121: */
Please fix the indentation of the "*" for the this comment on CREDENTIALS_FILTER_PATTERN so it looks consistent.
src/java.management.rmi/share/classes/javax/management/remote/rmi/package-info.java line 325:
> 323: * @since 1.5
> 324: *
> 325: **/
Extra * `*/` is sufficient.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19263#discussion_r1607149187
PR Review Comment: https://git.openjdk.org/jdk/pull/19263#discussion_r1607146703
More information about the serviceability-dev
mailing list