RFR: 8332641: Update nsk.share.jpda.Jdb to don't use finalization
Chris Plummer
cjplummer at openjdk.org
Wed May 22 16:57:10 UTC 2024
On Tue, 21 May 2024 21:49:51 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and output streams.
>
> The fix renames the method to close() and calls it explicitly after the test finishes. I verified that close() called for each nsk share jdb test.
>
> The jdb is also LocalProcess with it's own cleanup(). This part still remains the same so far.
Looks good.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19336#pullrequestreview-2071834856
More information about the serviceability-dev
mailing list