RFR: 8332641: Update nsk.share.jpda.Jdb to don't use finalization
Leonid Mesnik
lmesnik at openjdk.org
Fri May 24 17:34:07 UTC 2024
On Wed, 22 May 2024 16:54:13 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and output streams.
>>
>> The fix renames the method to close() and calls it explicitly after the test finishes. I verified that close() called for each nsk share jdb test.
>>
>> The jdb is also LocalProcess with it's own cleanup(). This part still remains the same so far.
>
> Looks good.
@plummercj, @kevinjwalls Thank you for reviews.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19336#issuecomment-2130052548
More information about the serviceability-dev
mailing list