RFR: 8332631: Update nsk.share.jpda.BindServer to don't use finalization

[Serguei Spitsyn]

On Tue, 21 May 2024 19:55:01 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The BindServer starts several threads and opens streams.
> 
> It registered them for cleanup using "Finalizer" from nsk.share.framework. Currently, it cleanup resources during shutdown hook.
> 
> This fix changes BindServer to explicitly close streams and finish threads after test is completed. The exceptions are just printed like it was done previously. I haven't caught any exception during in close method during testing.

Looks good. Posted one nit though.

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java line 388:

> 386:      * @see ServingThread
> 387:      */
> 388:     private static class ListeningThread extends Thread implements AutoCloseable{

Nit: Space is missed before '{'.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19335#pullrequestreview-2073933557
PR Review Comment: https://git.openjdk.org/jdk/pull/19335#discussion_r1611671166