RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

Chris Plummer cjplummer at openjdk.org
Tue May 28 22:55:02 UTC 2024


On Tue, 28 May 2024 20:24:31 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> I verified that debuggee process is killed before test finishes. (Just by printing it's status.)

What about when the test fails?

test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/exit/exit001.java line 177:

> 175: 
> 176:         int code = debuggee.waitFor();
> 177:         if (code != 0) {

Why do the other tests check for Consts.JCK_STATUS_BASE, but here we check for 0?

-------------

PR Review: https://git.openjdk.org/jdk/pull/19437#pullrequestreview-2083968139
PR Review Comment: https://git.openjdk.org/jdk/pull/19437#discussion_r1617970400


More information about the serviceability-dev mailing list