RFR: 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

[Leonid Mesnik]

On Tue, 28 May 2024 22:51:36 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> The 
>> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeProcess.java
>> uses cleanup() to kill debuggee process.
>> 
>> However, most tests kill the debuggee process explicitly. I verified that debuggee process is killed before test finishes. (Just by printing it's status.)
>> 
>> The fix adds a few checks debuggee.waitFor() int tests that didn't check debuggee process code.
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/exit/exit001.java line 177:
> 
>> 175: 
>> 176:         int code = debuggee.waitFor();
>> 177:         if (code != 0) {
> 
> Why do the other tests check for Consts.JCK_STATUS_BASE, but here we check for 0?

This is  a vm exit command test.
The test explicitly calls
'      vm.exit(0);' 
in line 157. So exit code is 0 and not "standard" 95.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19437#discussion_r1617975368