RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v4]

[Alexey Semenyuk]

On Thu, 31 Oct 2024 07:18:35 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code as appropriate. I am confident that in many cases this simplistic approach of commenting out code does not fix the underlying issue, and the warning actually found a bug that should be fixed. In these instances, I will be aiming to fix these bugs with help from reviewers, so I recommend anyone reviewing who knows more about the code than I do to see whether there is indeed a bug that needs fixing in a different way than what I did
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove global memHandle, would've liked to keep it as a comment :(

Changes requested by asemenyuk (Reviewer).

src/jdk.jpackage/windows/native/libjpackage/VersionInfo.cpp line 183:

> 181:     add32bitPadding(buf); // Padding2
> 182: 
> 183:  // const DWORD neutralLangId = (0x04b0 | MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL) << 16);

As ` neutralLangId` is unused, remove it instead of commenting it out.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21616#pullrequestreview-2423768191
PR Review Comment: https://git.openjdk.org/jdk/pull/21616#discussion_r1834382152