RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v4]
Julian Waters
jwaters at openjdk.org
Fri Nov 8 13:39:09 UTC 2024
On Fri, 8 Nov 2024 13:10:48 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove global memHandle, would've liked to keep it as a comment :(
>
> src/jdk.jpackage/windows/native/libjpackage/VersionInfo.cpp line 183:
>
>> 181: add32bitPadding(buf); // Padding2
>> 182:
>> 183: // const DWORD neutralLangId = (0x04b0 | MAKELANGID(LANG_NEUTRAL, SUBLANG_NEUTRAL) << 16);
>
> As ` neutralLangId` is unused, remove it instead of commenting it out.
Will do
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21616#discussion_r1834413246
More information about the serviceability-dev
mailing list