RFR: 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException

David Holmes dholmes at openjdk.org
Mon Nov 11 01:44:21 UTC 2024


On Fri, 8 Nov 2024 20:46:52 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> Looks like EmptyDomainNotificationTest has been working by accident for nearly 20 years.
> Removing notifications when not specifying a domain part of the ObjectName has actually been failing, but calling removeNotificationListener() without a domain has not been sharing the Exception.
> 
> ServerNotifForwarder.removeNotificationListener DOES need to add a domain part to an ObjectName that does not have one.
> 
> ServerNotifForwarder.addNotificationListener was changed in JDK-6238731, which is what this test is testing.
> 
> There is a numeric ID, BUT it still calls removeNotificationListener(ObjectName name, Integer listenerID) it does matter that the ObjectName does not match.
> 
> Maybe the failure to record and throw the Exceptions was the reason it was thought the numeric ID made the domain unnecessary.

I had to add the test to the ProblemList, so please remove it again. Thanks

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21993#pullrequestreview-2425962326


More information about the serviceability-dev mailing list