RFR: 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException [v2]
Kevin Walls
kevinw at openjdk.org
Mon Nov 11 09:18:34 UTC 2024
> Looks like EmptyDomainNotificationTest has been working by accident for nearly 20 years.
> Removing notifications when not specifying a domain part of the ObjectName has actually been failing, but calling removeNotificationListener() without a domain has not been sharing the Exception.
>
> ServerNotifForwarder.removeNotificationListener DOES need to add a domain part to an ObjectName that does not have one.
>
> ServerNotifForwarder.addNotificationListener was changed in JDK-6238731, which is what this test is testing.
>
> There is a numeric ID, BUT it still calls removeNotificationListener(ObjectName name, Integer listenerID) it does matter that the ObjectName does not match.
>
> Maybe the failure to record and throw the Exceptions was the reason it was thought the numeric ID made the domain unnecessary.
Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- Update problemlist
- Merge remote-tracking branch 'upstream/master' into 8343838_Notification
- 8343838: Test EmptyDomainNotificationTest.java fails with ListenerNotFoundException
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21993/files
- new: https://git.openjdk.org/jdk/pull/21993/files/5c9db437..1996528c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21993&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21993&range=00-01
Stats: 7640 lines in 253 files changed: 5119 ins; 1462 del; 1059 mod
Patch: https://git.openjdk.org/jdk/pull/21993.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21993/head:pull/21993
PR: https://git.openjdk.org/jdk/pull/21993
More information about the serviceability-dev
mailing list