RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v5]

[Serguei Spitsyn]

On Thu, 17 Oct 2024 23:11:34 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Actually I'm not so sure of your last statement. I think while in the FramePop callback the thread can do things that allow it to be suspended. So if the control thread has already detected that FramePop callback has been called, it may move on to the next iteration before the FramePop callback completes.
>
> Agreed, thanks.
> The interesting suspend point is in the `ThreadInVMfromJava()` destructor that is a part of the `JRT_BLOCK` macro.  I've pushed the fix now.

> I'm not sure what motivated the change to add old_notify_method. Maybe there was some other issue that was misunderstood.

The mach5 test runs hit some strange crashes in `deallocate()` and I've made a wrong conclusion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805579127