RFR: 8340698: JVMTI FRAME_POP event is sometimes missed if NotifyFramePop is called as a method is returning [v5]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Oct 17 23:35:44 UTC 2024
On Thu, 17 Oct 2024 23:17:48 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Agreed, thanks.
>> The interesting suspend point is in the `ThreadInVMfromJava()` destructor that is a part of the `JRT_BLOCK` macro. I've pushed the fix now.
>
>> I'm not sure what motivated the change to add old_notify_method. Maybe there was some other issue that was misunderstood.
>
> The mach5 test runs hit some strange crashes in `deallocate()` and I've made a wrong conclusion.
> So if the control thread has already detected that FramePop callback has been called, it may move on to the next iteration before the FramePop callback completes.
This is important point to understand about the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21468#discussion_r1805589349
More information about the serviceability-dev
mailing list