RFR: 8372098: Move AccessFlags to InstanceKlass [v5]

Chen Liang liach at openjdk.org
Tue Dec 2 17:17:44 UTC 2025


On Mon, 1 Dec 2025 15:02:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> ArrayKlass doesn't set AccessFlags so don't look for them there.  See CR for details.
>> Fixed SA and jvmci.  @iwanowww Can you check that I changed C2 correctly (we talked about this in August).
>> Tested with tier1-4.  5-7 in progress.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added a comment for checking interface guard after array guard.

src/hotspot/share/classfile/javaClasses.cpp line 1096:

> 1094:   // Set the raw access_flags, this is used by reflection instead of modifier flags.
> 1095:   // The Java code for array classes gets the access flags from the element type.
> 1096:   set_raw_access_flags(mirror(), k->is_array_klass() ? 0 : InstanceKlass::cast(k)->access_flags().as_unsigned_short());

Should we merge this is_array_klass() query with the main if-else block below? We can probably skip setting raw access flags for array classes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2578581321


More information about the serviceability-dev mailing list