RFR: 8372098: Move AccessFlags to InstanceKlass [v5]
Coleen Phillimore
coleenp at openjdk.org
Wed Dec 3 13:17:48 UTC 2025
On Mon, 1 Dec 2025 20:43:25 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added a comment for checking interface guard after array guard.
>
> src/hotspot/share/classfile/javaClasses.cpp line 1096:
>
>> 1094: // Set the raw access_flags, this is used by reflection instead of modifier flags.
>> 1095: // The Java code for array classes gets the access flags from the element type.
>> 1096: set_raw_access_flags(mirror(), k->is_array_klass() ? 0 : InstanceKlass::cast(k)->access_flags().as_unsigned_short());
>
> Should we merge this is_array_klass() query with the main if-else block below? We can probably skip setting raw access flags for array classes.
Yes, that would be an improvement. I'll still set them to zero (even though it can be elided), so that I can keep the comment for array types though.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2585064578
More information about the serviceability-dev
mailing list