RFR: 8279005: sun/tools/jstat tests do not check for test case exit codes after JDK-8245129 [v2]

[Chris Plummer]

On Tue, 24 Jun 2025 17:48:56 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Please review a jstat test-only fix.
>> 
>> 1. Ensure that jstat tests that run more than one sub-test per test file check the result of each sub-test before continuing.
>> 2. Allow '-' as a valid jstat -gcutil heap space percent occupancy field value, see lineCounts[1-4].awk. Occupancy is computed as ((capacity - used) / capacity), see src/jdk.jcmd/share/classes/sun/tools/jstat/resources/jstat_options, search for "gcutil". G1, ZGC, and Shenandoah may return zero capacity for any or all of survivor spaces, eden, old gen, metaspace, and compressed class space, leading to an occupancy result represented by '-'.
>> 
>> Modified tests pass.
>
> Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into 8279005
>  - 8279005: sun/tools/jstat tests do not check for test case exit codes after JDK-8245129

Changes look good. I think you can also close [JDK-8268485](https://bugs.openjdk.org/browse/JDK-8268485)

test/jdk/sun/tools/jstat/lineCounts1.awk line 32:

> 30: 	}
> 31: 
> 32: /^[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+\.[0-9]+$/	{

This would be a lot easier to read if written to verify that the `[ ]*([0-9]+.[0-9]+|-)` pattern appears 13 times, but I suppose that would be allowing a `-` in some cases that currently don't allow it.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25951#pullrequestreview-2955620503
PR Review Comment: https://git.openjdk.org/jdk/pull/25951#discussion_r2165077204