RFR: 8279005: sun/tools/jstat tests do not check for test case exit codes after JDK-8245129 [v2]

[Paul Hohensee]

On Tue, 24 Jun 2025 22:55:04 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Paul Hohensee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8279005
>>  - 8279005: sun/tools/jstat tests do not check for test case exit codes after JDK-8245129
>
> Changes look good. I think you can also close [JDK-8268485](https://bugs.openjdk.org/browse/JDK-8268485)

Thanks for the review, @plummercj. Yes, [JDK-8268485](https://bugs.openjdk.org/browse/JDK-8268485) looks like a dup.

> test/jdk/sun/tools/jstat/lineCounts1.awk line 32:
> 
>> 30: 	}
>> 31: 
>> 32: /^[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+\.[0-9]+$/	{
> 
> This would be a lot easier to read if written to verify that the `[ ]*([0-9]+.[0-9]+|-)` pattern appears 13 times, but I suppose that would be allowing a `-` in some cases that currently don't allow it.

True.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25951#issuecomment-3002130888
PR Review Comment: https://git.openjdk.org/jdk/pull/25951#discussion_r2165117631