RFR: 8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called [v2]

[Chris Plummer]

On Thu, 20 Mar 2025 23:27:45 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The nsk_jvmti_setFailStatus() sometimes is called after test check results. In these cases the warning logs are generated and hide the real failure reasons. Also, I think it is a error-prone way to set and check error, since check might be just forgotten. Also, the test execution after failure might be incorrect and also make failure analysis harder.
>> So I think it makes sense to always fail when nsk_jvmti_setFailStatus() is called.
>> 
>> If this is going to work I'll rename it later and add add optional message to be more informative.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comment updated

Looks good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24040#pullrequestreview-2704378042