RFR: 8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called [v2]
Leonid Mesnik
lmesnik at openjdk.org
Thu Mar 20 23:27:45 UTC 2025
> The nsk_jvmti_setFailStatus() sometimes is called after test check results. In these cases the warning logs are generated and hide the real failure reasons. Also, I think it is a error-prone way to set and check error, since check might be just forgotten. Also, the test execution after failure might be incorrect and also make failure analysis harder.
> So I think it makes sense to always fail when nsk_jvmti_setFailStatus() is called.
>
> If this is going to work I'll rename it later and add add optional message to be more informative.
Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
comment updated
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24040/files
- new: https://git.openjdk.org/jdk/pull/24040/files/5982af70..5dae85f1
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24040&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24040&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/24040.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24040/head:pull/24040
PR: https://git.openjdk.org/jdk/pull/24040
More information about the serviceability-dev
mailing list