RFR: 8351375: nsk/jvmti/ tests should fail when nsk_jvmti_setFailStatus() is called [v2]

[Leonid Mesnik]

On Thu, 20 Mar 2025 16:17:28 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/hotswap/HotSwap.cpp line 157:
>> 
>>> 155:       NSK_DISPLAY0("CompiledMethodLoad event recieved in dead phase");
>>> 156:       return;
>>> 157:     }
>> 
>> Nit: Typos at L148: `GetMethodNamme` => `GetMethodName`, `is work` => `works`, `phasem` => `phase`
>> A suggestion is to reformulate the comment as below:
>> 
>>     // GetMethodName works in live phase only so just exit if the event is generated too late
>> 
>> 
>> Also, I wonder if we want to abort/fail in all cases when `phase == JVMTI_PHASE_DEAD`.
>
>> Also, I wonder if we want to abort/fail in all cases when phase == JVMTI_PHASE_DEAD.
> 
> I take it back. My suggestion does not look right.

comment fixed.
I haven't find in spec that event can't be generated in dead phase. So test should just ignore this event.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24040#discussion_r2008497470