RFR: 8356811: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee: part 4 [v2]

Chris Plummer cjplummer at openjdk.org
Thu May 15 23:11:51 UTC 2025


On Tue, 13 May 2025 22:11:25 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix comment to reference threadByFieldName()
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line 119:
> 
>> 117: 
>> 118:         // debuggee main class
>> 119:         mainClass = debuggee.classByName(DEBUGGEE_CLASS);
> 
> Maybe just move this into `try` and replace `debuggee.threadByFieldName` with `debuggee.threadByFieldNameOrThrow`?

@alexmenkov It looks like this could be done in almost every test in this PR. In some the `try` just needs to move about 8 lines up, but in others it's more like 20. There will be a lot of indentation diffs. Do you still want to see this change?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25190#discussion_r2092082041


More information about the serviceability-dev mailing list