RFR: 8356811: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee: part 4 [v2]

[Chris Plummer]

On Thu, 15 May 2025 23:08:48 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/stop/stop002.java line 119:
>> 
>>> 117: 
>>> 118:         // debuggee main class
>>> 119:         mainClass = debuggee.classByName(DEBUGGEE_CLASS);
>> 
>> Maybe just move this into `try` and replace `debuggee.threadByFieldName` with `debuggee.threadByFieldNameOrThrow`?
>
> @alexmenkov It looks like this could be done in almost every test in this PR. In some the `try` just needs to move about 8 lines up, but in others it's more like 20. There will be a lot of indentation diffs. Do you still want to see this change?

It looks like there were some changes in part 3 that could also benefit from this. Perhaps this would be better off done in a followup PR. It will keep this PR easier to review, will make moving the `try` easier to review, and will pickup some additional tests that could use this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25190#discussion_r2092235925