RFR: 8353955: nsk/jdi tests should be fixed to not always require includevirtualthreads=y [v10]
Leonid Mesnik
lmesnik at openjdk.org
Tue May 20 22:07:54 UTC 2025
On Tue, 20 May 2025 21:52:09 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
> It means launch the debug agent with includevirtualthreads=y. It does the same regardless of the test factory type. Probably the logic that actually passes the argument (see the change in Binder.java) could be modified to only do so when using the virtual thread factory, but it is harmless to add it when running only with platform threads.
Thanks for explanation. The fix looks good. The only one question - if it does make sense to run test suite in 2 modes: with and without -includevirtualthreads or force -includevirtualthreads when virtual threads are enabled? Does it provide any additional coverage or only spending efforts.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24606#issuecomment-2895937748
More information about the serviceability-dev
mailing list