RFR: 8353955: nsk/jdi tests should be fixed to not always require includevirtualthreads=y [v10]

[Chris Plummer]

On Tue, 20 May 2025 22:04:54 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> Thanks for explanation. The fix looks good. The only one question - if it does make sense to run test suite in 2 modes: with and without -includevirtualthreads or force -includevirtualthreads when virtual threads are enabled? Does it provide any additional coverage or only spending efforts.

We could run with all tests using includevirtualthreads=y, which is basically what we have been doing. I don't think that testing is very useful. Debuggers in general aren't using (and shouldn't be using) includevirtualthreads=y. The main reason it was added was so we could run our test suites because so many tests relied on vm.allThreads() returning the debuggee virtual threads.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24606#issuecomment-2896009954