RFR: 8351194: Clean up Hotspot SA after 32-bit x86 removal [v6]

[Chris Plummer]

On Thu, 23 Oct 2025 13:05:49 GMT, Kerem Kat <krk at openjdk.org> wrote:

>> Remove 32-bit x86 specific code from the HotSpot Serviceability Agent following the removal of 32-bit x86 support.
>> 
>> - Removed x86-specific implementations and ifdef blocks.
>> - Renamed files with X86 in the name when they are also used from AMD64, e.g. `X86Frame` → `AMD64Frame`.
>> - Cleaned up platform detection logic in `PlatformInfo`.
>> - Updated documentation references.
>
> Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge branch 'master' into clean-x86-sa-JDK-8351194
>  - fix comments
>  - Revert "run RotateLeftNode*IdealizationTests on amd64 too"
>    
>    This reverts commit 1011b304f7cb4d195efc9239acd7784053c67cc1.
>  - requires hsdis
>  - run RotateLeftNode*IdealizationTests on amd64 too
>  - Merge branch 'master' into clean-x86-sa-JDK-8351194
>  - Merge branch 'master' into clean-x86-sa-JDK-8351194
>  - Clean up Hotspot SA after 32-bit x86 removal

Changes requested by cjplummer (Reviewer).

src/jdk.hotspot.agent/doc/hsdb.html line 34:

> 32:  <li> Class Browser - view Java classes, bytecode disassembly,
> 33:    or create .class files for selected classes
> 34:  <li> native disassembly (required hsdis) and nmethod disassembly with annotations for safepoint details.

Suggestion:

 <li> native disassembly (requires hsdis) and nmethod disassembly with annotations for safepoint details.

-------------

PR Review: https://git.openjdk.org/jdk/pull/27844#pullrequestreview-3390503752
PR Review Comment: https://git.openjdk.org/jdk/pull/27844#discussion_r2470817257