RFR: 8351194: Clean up Hotspot SA after 32-bit x86 removal [v6]

Kerem Kat krk at openjdk.org
Wed Oct 29 14:13:52 UTC 2025


On Tue, 28 Oct 2025 19:34:59 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Kerem Kat has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge branch 'master' into clean-x86-sa-JDK-8351194
>>  - fix comments
>>  - Revert "run RotateLeftNode*IdealizationTests on amd64 too"
>>    
>>    This reverts commit 1011b304f7cb4d195efc9239acd7784053c67cc1.
>>  - requires hsdis
>>  - run RotateLeftNode*IdealizationTests on amd64 too
>>  - Merge branch 'master' into clean-x86-sa-JDK-8351194
>>  - Merge branch 'master' into clean-x86-sa-JDK-8351194
>>  - Clean up Hotspot SA after 32-bit x86 removal
>
> src/jdk.hotspot.agent/doc/hsdb.html line 34:
> 
>> 32:  <li> Class Browser - view Java classes, bytecode disassembly,
>> 33:    or create .class files for selected classes
>> 34:  <li> native disassembly (required hsdis) and nmethod disassembly with annotations for safepoint details.
> 
> Suggestion:
> 
>  <li> native disassembly (requires hsdis) and nmethod disassembly with annotations for safepoint details.

Sorry, not sure how this keeps coming back.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27844#discussion_r2473321258


More information about the serviceability-dev mailing list