RFR: 8365057: Add support for java.util.concurrent lock information to Thread.dump_to_file [v2]
David Holmes
dholmes at openjdk.org
Thu Sep 25 02:06:31 UTC 2025
On Thu, 25 Sep 2025 01:40:20 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> feedback
>
> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java line 688:
>
>> 686:
>> 687: /**
>> 688: * Returns true if lines of a plain text thread dump containing the given text.
>
> Nit: Should it be: "...if lines of a plain text thread dump **is** containing" ?
The original "contain" was correct. Alternatively:
> Returns true if lines is a plain text thread dump containing the given text.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27457#discussion_r2377472427
More information about the serviceability-dev
mailing list