RFR: 8365057: Add support for java.util.concurrent lock information to Thread.dump_to_file [v2]
Alex Menkov
amenkov at openjdk.org
Thu Sep 25 19:34:02 UTC 2025
On Thu, 25 Sep 2025 02:02:03 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/DumpThreads.java line 688:
>>
>>> 686:
>>> 687: /**
>>> 688: * Returns true if lines of a plain text thread dump containing the given text.
>>
>> Nit: Should it be: "...if lines of a plain text thread dump **is** containing" ?
>
> The original "contain" was correct. Alternatively:
>> Returns true if lines is a plain text thread dump containing the given text.
Well.. this was Alan's request to update the comment.
To me original comment was clear and correct.
@AlanBateman , what do you prefer to see here:
- Returns true if lines of a plain text thread dump contain the given text. (original)
- Returns true if lines of a plain text thread dump is containing the given text.
- Returns true if lines is a plain text thread dump containing the given text.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27457#discussion_r2380081779
More information about the serviceability-dev
mailing list