RFR: 8365057: Add support for java.util.concurrent lock information to Thread.dump_to_file [v2]
Alan Bateman
alanb at openjdk.org
Fri Sep 26 06:01:19 UTC 2025
On Thu, 25 Sep 2025 19:08:40 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> The original "contain" was correct. Alternatively:
>>> Returns true if lines is a plain text thread dump containing the given text.
>
> Well.. this was Alan's request to update the comment.
> To me original comment was clear and correct.
> @AlanBateman , what do you prefer to see here:
> - Returns true if lines of a plain text thread dump contain the given text. (original)
> - Returns true if lines of a plain text thread dump is containing the given text.
> - Returns true if lines is a plain text thread dump containing the given text.
Apologies, it was a typo in a separate branch used for prototype. So ignore my comment, I think left the existing comment on the test method as is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27457#discussion_r2380945985
More information about the serviceability-dev
mailing list