RFR (S): Break too long source lines

Roman Kennke rkennke at redhat.com
Thu Nov 24 20:42:14 UTC 2016


Am Donnerstag, den 24.11.2016, 18:51 +0100 schrieb Aleksey Shipilev:
> Hi,
> 
> In case you haven't noticed, some webrevs look awful because there
> are
> too long lines in our sources (even my 2560x1440 monitor does not fit
> them!).
> 
> Let's trim the worst offenders down (good luck reviewing this):
> 
> http://cr.openjdk.java.net/~shade/shenandoah/so-long-it-wouldnt-
> fit/webrev.01/

Looks good.

I am not 100% familiar with that syntax:

+      log_develop_trace(gc)("Choose region " SIZE_FORMAT " with
garbage = " SIZE_FORMAT \
+                            " and live = " SIZE_FORMAT " and
_garbage_threshold = " SIZE_FORMAT "\n",

is the trailing \ needed here? Is this c++ multiline string literals?



Please push! (I'll merge my refactoring...)

Roman


More information about the shenandoah-dev mailing list