RFR (S): Break too long source lines
Aleksey Shipilev
shade at redhat.com
Fri Nov 25 11:37:05 UTC 2016
On 11/24/2016 09:42 PM, Roman Kennke wrote:
> Am Donnerstag, den 24.11.2016, 18:51 +0100 schrieb Aleksey Shipilev:
>> http://cr.openjdk.java.net/~shade/shenandoah/so-long-it-wouldnt-
>> fit/webrev.01/
>
> Looks good.
>
> I am not 100% familiar with that syntax:
>
> + log_develop_trace(gc)("Choose region " SIZE_FORMAT " with
> garbage = " SIZE_FORMAT \
> + " and live = " SIZE_FORMAT " and
> _garbage_threshold = " SIZE_FORMAT "\n",
>
> is the trailing \ needed here? Is this c++ multiline string literals?
Sure, we don't need \ there. I am pushing the rebased version:
http://cr.openjdk.java.net/~shade/shenandoah/so-long-it-wouldnt-fit/webrev.02/
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list