RFR: Heuristics fix, refactoring + 2 new heuristics
Aleksey Shipilev
shade at redhat.com
Tue Nov 29 11:47:28 UTC 2016
On 11/29/2016 12:13 PM, Roman Kennke wrote:
> http://cr.openjdk.java.net/~rkennke/heuristics/webrev.00/
Major nits:
*) In GlobalHeuristics you count in immediate_garbage, but in AdaptiveHeuristics, you don't? Why?
Miinor nits:
*) "compareHeapRegionsByGarbage" -- Camel-case is not HS code style.
*) Missing whitespace and probably bad grammar:
immediate" SIZE_FORMAT "
...should be like this?
"Choose region " SIZE_FORMAT " for immediate reclaim with garbage = " SIZE_FORMAT
Looks good otherwise.
Thanks,
-Aleksey
More information about the shenandoah-dev
mailing list