RFR: Heuristics fix, refactoring + 2 new heuristics

Roman Kennke rkennke at redhat.com
Tue Nov 29 12:33:51 UTC 2016


Am Dienstag, den 29.11.2016, 12:47 +0100 schrieb Aleksey Shipilev:
> On 11/29/2016 12:13 PM, Roman Kennke wrote:
> > http://cr.openjdk.java.net/~rkennke/heuristics/webrev.00/
> 
> Major nits:
> 
>  *) In GlobalHeuristics you count in immediate_garbage, but in
> AdaptiveHeuristics, you don't? Why?

Oversight.

> Miinor nits:
> 
>  *) "compareHeapRegionsByGarbage" -- Camel-case is not HS code style.
> 
>  *) Missing whitespace and probably bad grammar:
>       immediate" SIZE_FORMAT "
>     ...should be like this?
>       "Choose region " SIZE_FORMAT " for immediate reclaim with
> garbage = " SIZE_FORMAT
> 
> Looks good otherwise.

All of this fixed, plus a little minor refactoring in printing the
thresholds. Before we would first print them, and then set their
defaults...

http://cr.openjdk.java.net/~rkennke/heuristics/webrev.01/

Ok?

Roman


More information about the shenandoah-dev mailing list