RFR: Store verification
Roman Kennke
rkennke at redhat.com
Fri Oct 21 13:01:15 UTC 2016
Am Donnerstag, den 20.10.2016, 17:41 +0100 schrieb Andrew Haley:
> On 20/10/16 17:31, Roman Kennke wrote:
> >
> > We've got 3 loadStore() methods, and one MOV_VOLATILE macro, and
> > they
> > are multiline, 2 of them >10lines and duplicating those, with only
> > 1
> > line difference seems ugly...
>
> No, I meant I didn't mind you defining a method using the true and
> false
> but only using it twice, once from a doLoad() and once from a
> doStore()
> method. But never mind.
ok. I went for the enum. I agree, it does look better/clearer.
I also changed the orr back to mov and renamed the set/get_cflags() to
set/get_nzcv(), and incorporated Roland's suggestions about the
conditions (oops) and the store-checks in x86_64.ad.
http://cr.openjdk.java.net/~rkennke/storechecks/webrev.01/
Ok now?
Roman
More information about the shenandoah-dev
mailing list