RFR(XS) Fixed calling convention of shenandoah_wb() C entry on Windows

Andrew Haley aph at redhat.com
Tue Aug 1 13:16:07 UTC 2017


On 01/08/17 10:48, Aleksey Shipilev wrote:
> On 07/26/2017 09:31 PM, Zhengyu Gu wrote:
>> On Windows with VS, the first argument is passed in RCX instead of RDI (Linux/gcc). There is the VS
>> 2015 document: https://msdn.microsoft.com/en-us/library/9z1stfyw.aspx
>>
>>
>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/windows_c_call/webrev.00/

This looks like the wrong thing to do.  You should use c_rarg0, not
a #ifdef _WINDOWS.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the shenandoah-dev mailing list