RFR(XS) Fixed calling convention of shenandoah_wb() C entry on Windows
Zhengyu Gu
zgu at redhat.com
Tue Aug 1 15:04:01 UTC 2017
Hi Andrew,
Thanks for pointing out. How about this:
Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/windows_c_call/webrev.01/
Test:
hotspot_gc_shenandoah: on Windows and Linux.
Thanks,
-Zhengyu
On 08/01/2017 09:16 AM, Andrew Haley wrote:
> On 01/08/17 10:48, Aleksey Shipilev wrote:
>> On 07/26/2017 09:31 PM, Zhengyu Gu wrote:
>>> On Windows with VS, the first argument is passed in RCX instead of RDI (Linux/gcc). There is the VS
>>> 2015 document: https://msdn.microsoft.com/en-us/library/9z1stfyw.aspx
>>>
>>>
>>> Webrev: http://cr.openjdk.java.net/~zgu/shenandoah/windows_c_call/webrev.00/
>
> This looks like the wrong thing to do. You should use c_rarg0, not
> a #ifdef _WINDOWS.
>
More information about the shenandoah-dev
mailing list